appDisplay: Stop using toggle-mode with folder icons

This is essentially a left-over from the original folder design, dating
all the way back to commit 6e3e2d9 in 2013.

It no longer makes much sense with the current design iteration, where
we pretend that the icon pops out of the grid and becomes the dialog
(i.e. we hide the icon and zoom out the dialog from its position).

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4114>
(cherry picked from commit e781d8155ab312a1335dd3082dfd8abfef8430b9)

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 02ddc949be014c63a69bd0867e87fd29860e3fe9..968b7b8188f3d5257fc16358563d3cea3795bbef 100644 (file)
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2279,7 +2279,6 @@ export const FolderIcon = GObject.registerClass({
         super._init({
             style_class: 'overview-tile app-folder',
             button_mask: St.ButtonMask.ONE,
-            toggle_mode: true,
             can_focus: true,
         }, global.settings.is_writable('app-picker-layout'));
         this._id = id;
@@ -2441,9 +2440,6 @@ export const FolderIcon = GObject.registerClass({
                     mode,
                     delay: isOpen ? 0 : FOLDER_DIALOG_ANIMATION_TIME - duration,
                 });
-
-                if (!isOpen)
-                    this.checked = false;
             });
         }
     }